Skip to content

Add feature flag for Smartling integration work#3231

Merged
thecristen merged 7 commits into
mainfrom
lb/add-feature-flag-for-smartling-integration-work
Jun 16, 2026
Merged

Add feature flag for Smartling integration work#3231
thecristen merged 7 commits into
mainfrom
lb/add-feature-flag-for-smartling-integration-work

Conversation

@lilybarrett

@lilybarrett lilybarrett commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Scope

We are beginning to build a Smartling integration to provide translations for DotCom pages.

Asana Ticket: https://app.asana.com/1/15492006741476/project/1213994587940653/task/1214847371994672?focus=true

Implementation

  • Made some changes to a fork of Laboratory here for it to be compatible with DotCom.
  • Added Laboratory library to DotCom, along with a new flag for upcoming integration work.

@lilybarrett lilybarrett requested a review from a team as a code owner June 4, 2026 19:02
@lilybarrett lilybarrett marked this pull request as draft June 4, 2026 19:15
@lilybarrett

lilybarrett commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

When you navigate to localhost:4001/_flags, ideally you should see some UI for toggling the flag on and off. However, I only see the unrendered HTML. Curious if you have any insight/suggestions, @arkadyan or @thecristen?

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="description" content="">
    <meta name="author" content="">

    <link rel="stylesheet" href="/_flags/css/app.css">
    <title>Laboratory</title>
  </head>

  <body>
    <div class="window">
      <div class="window-header">
        <div class="window-title">Features</div>
      </div>
      <div class="window-body">
        <ul class="feature-rows">
          
            <li class="feature-row disabled">
              <div class="feature-name">Smartling translations</div>
              <div class="feature-description">Uses Smartling's translation workflows</div>
              <div class="button">
                
                  <form action="/_flags/enable/use_smartling_translations" method="post">
                      <input class="button-text" type="submit" value="Enable" />
                  </form>
                
              </div>
            </li>
          
        </ul>
      </div>
    </div>
  </body>
</html>

@thecristen

thecristen commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

@lilybarrett That's consistent with how I've experienced the Laboratory library before! 😅 I wonder if the hardcoded link to a CSS file ever worked. Anyways, totally fine with an unstyled version.

@lilybarrett lilybarrett force-pushed the lb/add-feature-flag-for-smartling-integration-work branch from ccefc2c to 1e6e4f7 Compare June 15, 2026 15:43
@lilybarrett lilybarrett marked this pull request as ready for review June 15, 2026 15:51
@thecristen thecristen added the dev-green Deploy to dev-green label Jun 15, 2026
thecristen
thecristen requested changes Jun 15, 2026
View reviewed changes
Comment thread config/dev.exs Outdated
@lilybarrett lilybarrett added dev-green Deploy to dev-green and removed dev-green Deploy to dev-green labels Jun 15, 2026
@lilybarrett lilybarrett requested a review from thecristen June 15, 2026 18:41
@lvachon1

lvachon1 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The flag screen works, nice! This should be a great tool for us in the future.
Screenshot 2026-06-16 at 11 53 54 AM

thecristen
thecristen approved these changes Jun 16, 2026
View reviewed changes

@thecristen thecristen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you!

@thecristen thecristen merged commit 202a197 into main Jun 16, 2026
22 checks passed
@thecristen thecristen deleted the lb/add-feature-flag-for-smartling-integration-work branch June 16, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thecristen thecristen thecristen approved these changes

@lvachon1 lvachon1 Awaiting requested review from lvachon1 lvachon1 is a code owner automatically assigned from mbta/dotcom

@arkadyan arkadyan Awaiting requested review from arkadyan

Assignees

No one assigned

Labels

dev-green Deploy to dev-green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lilybarrett @thecristen @lvachon1